Comments on: And We’re Back http://girtby.net/archives/2008/12/01/and-were-back/ this blog is girtby.net Wed, 30 Sep 2009 01:44:34 -0400 http://wordpress.org/?v=2.9-rare hourly 1 By: alastair http://girtby.net/archives/2008/12/01/and-were-back/comment-page-1/#comment-1952 alastair Wed, 10 Dec 2008 10:53:53 +0000 http://blog.girtby.info/?p=3614#comment-1952 <p>Julian: thanks for the <code>rel</code> -> <code>ref</code> correction. After two separate patches to wordpress, and manually updating all my comments with the correct URL, my comments feed now validates!</p> <p>(And <em>still</em> I haven't started on the CSS...)</p> Julian: thanks for the rel -> ref correction. After two separate patches to wordpress, and manually updating all my comments with the correct URL, my comments feed now validates!

(And still I haven’t started on the CSS…)

]]> By: alastair http://girtby.net/archives/2008/12/01/and-were-back/comment-page-1/#comment-1951 alastair Wed, 10 Dec 2008 10:31:15 +0000 http://blog.girtby.info/?p=3614#comment-1951 <p>Thanks Julian, but you're seeing the comments feed <em>after</em> I patched wordpress. For the record, here's the patch:</p> <pre><code>=== modified file 'wp-includes/feed-atom-comments.php' --- wp-includes/feed-atom-comments.php 2008-12-04 17:47:50 +0000 +++ wp-includes/feed-atom-comments.php 2008-12-10 02:21:46 +0000 @@ -12,6 +12,7 @@ xmlns="http://www.w3.org/2005/Atom" xml:lang="<?php echo get_option('rss_language'); ?>" <?php do_action('atom_ns'); ?> + xmlns:thr="http://purl.org/syndication/thread/1.0" > <title type="text"><?php if ( is_singular() ) </code></pre> <p>Yes, a missing namespace declaration; pretty basic stuff.</p> <p>I would raise a ticket in Wordpress trac but I've forgotten my original password, and for some reason it seems to be using different credentials to the rest of the site, so a password reset doesn't seem to be working, and ... Argh!</p> <p>BTW the "http://" issue should be fixed now, not sure if it's an artifact of the Mephisto migration or not (actually I suspect not).</p> Thanks Julian, but you’re seeing the comments feed after I patched wordpress. For the record, here’s the patch:

=== modified file 'wp-includes/feed-atom-comments.php'
--- wp-includes/feed-atom-comments.php  2008-12-04 17:47:50 +0000
+++ wp-includes/feed-atom-comments.php  2008-12-10 02:21:46 +0000
@@ -12,6 +12,7 @@
    xmlns="http://www.w3.org/2005/Atom"
    xml:lang="<?php echo get_option('rss_language'); ?>"
    <?php do_action('atom_ns'); ?>
+   xmlns:thr="http://purl.org/syndication/thread/1.0"
 >
    <title type="text"><?php
        if ( is_singular() )

Yes, a missing namespace declaration; pretty basic stuff.

I would raise a ticket in Wordpress trac but I’ve forgotten my original password, and for some reason it seems to be using different credentials to the rest of the site, so a password reset doesn’t seem to be working, and … Argh!

BTW the “http://” issue should be fixed now, not sure if it’s an artifact of the Mephisto migration or not (actually I suspect not).

]]> By: Julian http://girtby.net/archives/2008/12/01/and-were-back/comment-page-1/#comment-1950 Julian Wed, 10 Dec 2008 04:51:05 +0000 http://blog.girtby.info/?p=3614#comment-1950 <p>I requested that the WordPress team re-open a <a href="http://trac.wordpress.org/ticket/8292" rel="nofollow">recent enhancement ticket</a> to fix the damage that was done. </p> <p>This was introduced 3 weeks ago; you are running a beta version of WordPress. (Now I <em>am</em> defending WordPress!)</p> I requested that the WordPress team re-open a recent enhancement ticket to fix the damage that was done.

This was introduced 3 weeks ago; you are running a beta version of WordPress. (Now I am defending WordPress!)

]]> By: Julian http://girtby.net/archives/2008/12/01/and-were-back/comment-page-1/#comment-1949 Julian Wed, 10 Dec 2008 04:39:04 +0000 http://blog.girtby.info/?p=3614#comment-1949 <p>Hmmm... you may have stumbled over an WP 7 RC1 bug!</p> <p>I am not an expert in Atom, but it looks like it is using <code>rel</code> attribute where it means <code>ref</code>. I will wander over and see if I can escalate.</p> Hmmm… you may have stumbled over an WP 7 RC1 bug!

I am not an expert in Atom, but it looks like it is using rel attribute where it means ref. I will wander over and see if I can escalate.

]]> By: Julian http://girtby.net/archives/2008/12/01/and-were-back/comment-page-1/#comment-1948 Julian Wed, 10 Dec 2008 04:30:30 +0000 http://blog.girtby.info/?p=3614#comment-1948 <p>My Atom comment feed is validating fine. (WP 2.6.5)</p> <p>(I am just adding a data-point, not defending WordPress nor dismissing your complaint with "It works for me.")</p> <p>Look at the user record for your login account (maybe called "admin", maybe "Alastair"). There is a field where you can enter a Website. My guess is that you have the text "http://" in that field. That would account for one of the two validation errors. </p> <p>The other one is beyond me.</p> My Atom comment feed is validating fine. (WP 2.6.5)

(I am just adding a data-point, not defending WordPress nor dismissing your complaint with “It works for me.”)

Look at the user record for your login account (maybe called “admin”, maybe “Alastair”). There is a field where you can enter a Website. My guess is that you have the text “http://” in that field. That would account for one of the two validation errors.

The other one is beyond me.

]]> By: alastair http://girtby.net/archives/2008/12/01/and-were-back/comment-page-1/#comment-1946 alastair Wed, 10 Dec 2008 01:59:19 +0000 http://blog.girtby.info/?p=3614#comment-1946 <p>OK, it looks like Wordpress is outputting malformed XML in the Atom comments feed. WTF, Atom <em>still</em> isn't fixed in Wordpress? FFS.</p> OK, it looks like Wordpress is outputting malformed XML in the Atom comments feed. WTF, Atom still isn’t fixed in Wordpress? FFS.

]]> By: alastair http://girtby.net/archives/2008/12/01/and-were-back/comment-page-1/#comment-1938 alastair Tue, 09 Dec 2008 11:12:05 +0000 http://blog.girtby.info/?p=3614#comment-1938 <p>Thanks Matt.</p> <p>If nothing else wrestling with CSS will at least make a change from mod_rewrite, which doesn't make me happy either.</p> Thanks Matt.

If nothing else wrestling with CSS will at least make a change from mod_rewrite, which doesn’t make me happy either.

]]> By: alastair http://girtby.net/archives/2008/12/01/and-were-back/comment-page-1/#comment-1937 alastair Tue, 09 Dec 2008 11:10:45 +0000 http://blog.girtby.info/?p=3614#comment-1937 <p>Richard: the comments feed should be back now. Or more accurately, the 301 redirection from the various old comments feed URLs should be in place now. Let me know if not! </p> <p>Brendan: is it still happening?</p> Richard: the comments feed should be back now. Or more accurately, the 301 redirection from the various old comments feed URLs should be in place now. Let me know if not!

Brendan: is it still happening?

]]> By: Matt Quail http://girtby.net/archives/2008/12/01/and-were-back/comment-page-1/#comment-1936 Matt Quail Tue, 09 Dec 2008 09:54:13 +0000 http://blog.girtby.info/?p=3614#comment-1936 <p>Yeah the Sandbox theme is reasonably compelling. Customizing the CSS for Sandbox is not too daunting, I wrote up my process here http://madbean.com/2008/sandbox-child-theme/</p> <p>I was going to say "Happy CSSing", but CSSing never really makes you happy.</p> Yeah the Sandbox theme is reasonably compelling. Customizing the CSS for Sandbox is not too daunting, I wrote up my process here http://madbean.com/2008/sandbox-child-theme/

I was going to say “Happy CSSing”, but CSSing never really makes you happy.

]]> By: Richard Atkins http://girtby.net/archives/2008/12/01/and-were-back/comment-page-1/#comment-1935 Richard Atkins Tue, 09 Dec 2008 08:47:06 +0000 http://blog.girtby.info/?p=3614#comment-1935 <p>Coincidentally, the old atom comments feed has ceased to be, although Google Reader sees content in the old atom posts feed just fine. Is it just about damn time we all stopped using URLs that mention atom?</p> Coincidentally, the old atom comments feed has ceased to be, although Google Reader sees content in the old atom posts feed just fine. Is it just about damn time we all stopped using URLs that mention atom?

]]>